Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for windows10 platform #38

Merged
merged 5 commits into from
Sep 5, 2016
Merged

add support for windows10 platform #38

merged 5 commits into from
Sep 5, 2016

Conversation

3h3c
Copy link

@3h3c 3h3c commented Sep 1, 2016

No description provided.

@GillesC
Copy link
Collaborator

GillesC commented Sep 1, 2016

Could you proivide me some info, about what you've just done?
Because I'm not a Windows 10 dev.
For instance, I see a vault var, does this mean the stored value is encrypted in any way?

@3h3c
Copy link
Author

3h3c commented Sep 1, 2016

hey,

The PasswordVault lets application to store and retrieve user’s credentials in a secure way: all password are encrypted and cannot be accessed by other applications.

see: https://msdn.microsoft.com/de-de/library/windows/apps/windows.security.credentials.passwordvault.aspx

@GillesC
Copy link
Collaborator

GillesC commented Sep 1, 2016

I'll test your PR, if everything is OK. I'll merge it.

@alokrajiv
Copy link
Collaborator

Is the test suite passing?

@GillesC
Copy link
Collaborator

GillesC commented Sep 1, 2016

I'm installing the requirements for testing on Windows 10 :) I'll check the other platforms now.

@GillesC
Copy link
Collaborator

GillesC commented Sep 1, 2016

Android & browser passed the test.

@3h3c
Copy link
Author

3h3c commented Sep 5, 2016

hey,

any new news?

@GillesC
Copy link
Collaborator

GillesC commented Sep 5, 2016

I've installed VS 2015.
But I'm unable to run our test suite.
The following error occured: "Error: Properties.PublisherDisplayName elements must be non-empty in appxmanifest at undefined"

Extra info: command was "cordova run windows", and I had an available windows device "Available windows devices: 0. Device (device)".

@3h3c
Copy link
Author

3h3c commented Sep 5, 2016

try to build it with:

cordova build windows --arch="x86"
and run with cordova run windows --arch="x86"

@GillesC
Copy link
Collaborator

GillesC commented Sep 5, 2016

I got the same result:
image

@3h3c
Copy link
Author

3h3c commented Sep 5, 2016 •
edited
Loading

you have to change your config.xml.

add these lines:

<author email="example@example.com" href="http://example.com/">Example Company</author>

@GillesC
Copy link
Collaborator

GillesC commented Sep 5, 2016 •
edited
Loading

Windows: not passed

Things to do:

  • implementing correct error objects, see this.
  • getInt returns string instead of number

Please see this section to test your implementation. Change the git clone to your repo.

@GillesC
Copy link
Collaborator

GillesC commented Sep 5, 2016

Errors thrown because of 'Encryption' tests, can be disgarded because it isn't implemented in iOS. And Windows functionality has priority. So the only errors you can have are these related to the encryption methods.

@GillesC
Copy link
Collaborator

GillesC commented Sep 5, 2016 •
edited
Loading

Commit not confirmed.
The returned value is now undefinied. (Error: Expected undefined to equal 154243)

Debug output from VS:

'WWAHost.exe' (Script): Loaded 'Script Code (MSAppHost/2.0)'. 
Exception was thrown at line 37, column 5 in ms-appx://com.thecocoaproject.nativestoragedemo/www/plugins/cordova-plugin-test-framework/www/medic.js
0x800c0005 - JavaScript runtime error: The system cannot locate the resource specified.
Exception was thrown at line 1577, column 11 in ms-appx://com.thecocoaproject.nativestoragedemo/www/cdvtests/jasmine-2.4.1/jasmine.js
0x800a139e - JavaScript runtime error: Expected undefined to equal 154243.
Exception was thrown at line 15, column 13 in ms-appx://com.thecocoaproject.nativestoragedemo/www/plugins/cordova-plugin-nativestorage/src/windows/NativeStorage.js
0x80070490 - JavaScript runtime error: Element not found.

Cannot get credential from Vault
WinRT information: Cannot get credential from Vault
Exception was thrown at line 1577, column 11 in ms-appx://com.thecocoaproject.nativestoragedemo/www/cdvtests/jasmine-2.4.1/jasmine.js
0x800a139e - JavaScript runtime error: Expected 'failed to get Item from NativeStorage - Element not found.

Cannot get credential from Vault' to equal 2.
Exception was thrown at line 276, column 9 in ms-appx://com.thecocoaproject.nativestoragedemo/www/plugins/cordova-plugin-nativestorage/www/mainHandle.js
0x800a13aa - JavaScript runtime error: Circular reference in value argument not supported
Exception was thrown at line 1577, column 11 in ms-appx://com.thecocoaproject.nativestoragedemo/www/cdvtests/jasmine-2.4.1/jasmine.js
0x800a139e - JavaScript runtime error: Failed: Set item Failed
Exception was thrown at line 1577, column 11 in ms-appx://com.thecocoaproject.nativestoragedemo/www/cdvtests/jasmine-2.4.1/jasmine.js
0x800a139e - JavaScript runtime error: Failed: Set item Failed
Exception was thrown at line 35, column 13 in ms-appx://com.thecocoaproject.nativestoragedemo/www/plugins/cordova-plugin-nativestorage/src/windows/NativeStorage.js
0x800a1391 - JavaScript runtime error: 'packageId' is undefined
Exception was thrown at line 1577, column 11 in ms-appx://com.thecocoaproject.nativestoragedemo/www/cdvtests/jasmine-2.4.1/jasmine.js
0x800a139e - JavaScript runtime error: Failed: Error when clearing native storage
The program '[12076] WWAHost.exe' has exited with code 1 (0x1).

return right failure code
c8cdb4d 
tests from tests/main.js passed in my run
@GillesC GillesC closed this Sep 5, 2016
@GillesC GillesC reopened this Sep 5, 2016
@GillesC GillesC merged commit d87aed2 into TheCocoaProject:master Sep 5, 2016
@alokrajiv
Copy link
Collaborator

Are the tests passing? You merged it?

@GillesC
Copy link
Collaborator

GillesC commented Sep 5, 2016

Tests have passed, and it's merged! :)

@GillesC
Copy link
Collaborator

GillesC commented Sep 5, 2016

Gonna publish it to NPM now.

@GillesC
Copy link
Collaborator

GillesC commented Sep 5, 2016

Published on NPM

@davidofwatkins davidofwatkins mentioned this pull request Mar 24, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@3h3c @GillesC @alokrajiv